Replace Paver quality and js_test commands

.github/workflows/js-tests.yml

@@ -64,13 +64,15 @@ jobs:
           make base-requirements
 
       - uses: c-hive/gha-npm-cache@v1
+
+      - name: Install npm
+        run: npm ci  
+
       - name: Run JS Tests
-        env:
-          TEST_SUITE: js-unit
-          SCRIPT_TO_RUN: ./scripts/generic-ci-tests.sh
         run: |
           npm install -g jest
-          xvfb-run --auto-servernum ./scripts/all-tests.sh
+          xvfb-run --auto-servernum make test-js
+          make test-coverage
 
       - name: Save Job Artifacts
         uses: actions/upload-artifact@v4

.github/workflows/quality-checks.yml

@@ -60,16 +60,30 @@ jobs:
           PIP_SRC: ${{ runner.temp }}
         run: |
           make test-requirements
-
+
+      - name: Install npm
+        env:
+          PIP_SRC: ${{ runner.temp }}
+        run: npm ci  
+
+      - name: Install python packages
+        env:
+          PIP_SRC: ${{ runner.temp }}
+        run: |
+            pip install -e .
+
       - name: Run Quality Tests
         env:
-          TEST_SUITE: quality
-          SCRIPT_TO_RUN: ./scripts/generic-ci-tests.sh
           PIP_SRC: ${{ runner.temp }}
           TARGET_BRANCH: ${{ github.base_ref }}
         run: |
-          ./scripts/all-tests.sh
-
+            make pycodestyle
+            make eslint
+            make stylelint
+            make xsslint
+            make pi_check
+            make check_keyword
+
       - name: Save Job Artifacts
         if: always()
         uses: actions/upload-artifact@v4

Makefile

@@ -6,7 +6,7 @@
   guides help lint-imports local-requirements migrate migrate-lms migrate-cms \
   pre-requirements pull pull_xblock_translations pull_translations push_translations \
   requirements shell swagger \
-  technical-docs test-requirements ubuntu-requirements upgrade-package upgrade
+  technical-docs test-requirements ubuntu-requirements upgrade-package upgrade pep8_test
 
 # Careful with mktemp syntax: it has to work on Mac and Ubuntu, which have differences.
 PRIVATE_FILES := $(shell mktemp -u /tmp/private_files.XXXXXX)
@@ -204,3 +204,29 @@ migrate: migrate-lms migrate-cms
 # Part of https://github.com/openedx/wg-developer-experience/issues/136
 ubuntu-requirements: ## Install ubuntu 22.04 system packages needed for `pip install` to work on ubuntu.
 	sudo apt install libmysqlclient-dev libxmlsec1-dev
+
+eslint:
+	python scripts/quality_test/quality_test.py eslint
+
+stylelint:
+	python scripts/quality_test/quality_test.py stylelint
+
+xsslint:
+	python scripts/quality_test/quality_test.py xsslint
+
+pycodestyle:
+	pycodestyle .
+
+pi_check:
+	python scripts/quality_test/quality_test.py pii_check
+
+check_keyword:
+	python scripts/quality_test/quality_test.py check_keywords
+
+test-js:
+	python scripts/js_test.py --option jstest
+
+test-coverage:
+	python scripts/js_test.py --option coverage
+
+quality-test: pycodestyle eslint stylelint xsslint pi_check check_keyword

pavelib/__init__.py

@@ -3,4 +3,4 @@
 """
 
 
-from . import assets, js_test, prereqs, quality
+from . import assets