Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Paver quality and js_test commands #35159

Open
wants to merge 80 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 67 commits
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
e140ef0
chore: replace paver quality tests
salman2013 Jul 23, 2024
337f085
fix: remove un-used code
salman2013 Jul 23, 2024
145f2a4
chore: fix some lint errors
salman2013 Jul 23, 2024
06c9ec7
fix: fix lint errors
salman2013 Jul 23, 2024
7ded572
fix: fix method error
salman2013 Jul 23, 2024
afa2f9f
fix: fix the lint errors
salman2013 Jul 23, 2024
5a6e526
chore: remove paver tests for quality commands
salman2013 Jul 24, 2024
b8557dc
chore: remove paver tests for quality commands
salman2013 Jul 24, 2024
b551990
chore: remove paver tests for quality commands
salman2013 Jul 24, 2024
316ea9c
chore: remove pycodestyle violations and run the direct command
salman2013 Jul 30, 2024
fc71d83
fix: fixing tests
salman2013 Jul 30, 2024
424e220
fix: fix tests
salman2013 Jul 30, 2024
6b851cc
fix: trying eslint command from make file
salman2013 Jul 30, 2024
17ae7a5
fix: fixing tests
salman2013 Jul 30, 2024
71a7c73
chore: add stylelint test in quality workflow
salman2013 Jul 31, 2024
ec42adf
chore: add stylelint test in quality workflow
salman2013 Jul 31, 2024
e4d2d0f
Merge remote-tracking branch 'upstream/master' into salman/remove-pav…
salman2013 Jul 31, 2024
ad2e053
chore: fix tests
salman2013 Jul 31, 2024
7f44491
chore: fix tests
salman2013 Jul 31, 2024
e963d3f
chore: fix tests
salman2013 Jul 31, 2024
98b3cd3
chore: fix tests
salman2013 Jul 31, 2024
da74ec7
chore: fix tests
salman2013 Aug 1, 2024
5a1d6be
chore: fix tests
salman2013 Aug 1, 2024
ce7bd66
chore: fix tests
salman2013 Aug 2, 2024
8be4263
chore: fix tests
salman2013 Aug 2, 2024
7f716d8
fix: fixing tests
salman2013 Aug 5, 2024
f968721
fix: fixing tests
salman2013 Aug 5, 2024
d110d78
chore: fix tests
salman2013 Aug 5, 2024
6219edf
chore: replacing paver script
salman2013 Aug 7, 2024
a760774
chore: replacing paver script
salman2013 Aug 7, 2024
391e623
chore: replacing paver script
salman2013 Aug 7, 2024
dbcb8c7
chore: replacing paver script
salman2013 Aug 7, 2024
fab999e
chore: replacing paver script
salman2013 Aug 7, 2024
389f78d
chore: replacing paver script
salman2013 Aug 7, 2024
4215965
chore: replacing paver script
salman2013 Aug 7, 2024
96c1fd6
chore: replacing paver script
salman2013 Aug 7, 2024
61ccb36
chore: replacing paver script
salman2013 Aug 7, 2024
1625794
chore: replace eslint
salman2013 Aug 8, 2024
cc1fad5
chore: replace stylelint
salman2013 Aug 8, 2024
e18bc16
chore: replace stylelint
salman2013 Aug 8, 2024
2b6affb
fix: fix tests
salman2013 Aug 8, 2024
87068e0
fix: fix tests
salman2013 Aug 8, 2024
e0ad851
chore: remove some code related to prereq installation of python pack…
salman2013 Aug 8, 2024
747522b
fix: fix tests
salman2013 Aug 8, 2024
73934b6
fix: fix tests
salman2013 Aug 8, 2024
bf1d732
fix: fix tests
salman2013 Aug 9, 2024
0341535
fix: fix tests
salman2013 Aug 9, 2024
3ef3383
fix: fix tests
salman2013 Aug 9, 2024
9317537
chore: replace paver js tests
salman2013 Aug 13, 2024
b17915a
chore: replace paver js tests
salman2013 Aug 13, 2024
4a8356a
fix: fix tests
salman2013 Aug 13, 2024
167660c
fix: fix tests
salman2013 Aug 13, 2024
8b7d600
fix: fix tests
salman2013 Aug 13, 2024
03120da
fix: fix tests
salman2013 Aug 14, 2024
8f9b41f
fix: fix tests
salman2013 Aug 14, 2024
d8dedf0
fix: fix tests
salman2013 Aug 14, 2024
8ead7cd
fix: fix tests
salman2013 Aug 14, 2024
f175679
fix: fix tests
salman2013 Aug 14, 2024
28d53e1
fix: fix tests
salman2013 Aug 14, 2024
4611635
fix: fix tests
salman2013 Aug 15, 2024
a1cd00e
fix: fix tests
salman2013 Aug 15, 2024
25c69f3
fix: fix tests
salman2013 Aug 16, 2024
988b77a
chore: remove un-used code
salman2013 Aug 16, 2024
7c12911
chore: remove un-used code
salman2013 Aug 16, 2024
0cb7226
fix: fix tests
salman2013 Aug 16, 2024
029a9d8
chore: replace paver coverage tests
salman2013 Aug 20, 2024
90d58a2
fix: remove files which was accidentally added
salman2013 Aug 20, 2024
b323c64
fix: fix the comments received on PR review
salman2013 Aug 26, 2024
515080e
fix: fix tests
salman2013 Aug 26, 2024
ba666b1
fix: fix tests
salman2013 Aug 26, 2024
75ee133
fix: fix tests
salman2013 Aug 26, 2024
c63892f
fix: fix the pylint and unit tests
salman2013 Aug 27, 2024
5309160
fix: code improvements
salman2013 Aug 27, 2024
2f3169a
fix: fix the comments found in PR review
salman2013 Sep 10, 2024
75cf11c
fix: fix the commands with check=True
salman2013 Sep 12, 2024
c05f932
Merge branch 'master' into salman/remove-paver-commands
kdmccormick Oct 24, 2024
2c68035
fix: fix the comments, code improvements
salman2013 Nov 11, 2024
f53eab8
fix: testing changes in commands
salman2013 Nov 11, 2024
77476dd
fix: fix the code for stylelint removal
salman2013 Nov 11, 2024
26d5153
fix: fix the pii_check command for django setting module
salman2013 Nov 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/js-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,15 @@ jobs:
make base-requirements

- uses: c-hive/gha-npm-cache@v1

- name: Install npm
run: npm ci

- name: Run JS Tests
env:
TEST_SUITE: js-unit
SCRIPT_TO_RUN: ./scripts/generic-ci-tests.sh
run: |
npm install -g jest
xvfb-run --auto-servernum ./scripts/all-tests.sh
make test-js
make test-coverage

- name: Save Job Artifacts
uses: actions/upload-artifact@v4
Expand Down
24 changes: 19 additions & 5 deletions .github/workflows/quality-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,30 @@ jobs:
PIP_SRC: ${{ runner.temp }}
run: |
make test-requirements


- name: Install npm
env:
PIP_SRC: ${{ runner.temp }}
run: npm ci

- name: Install python packages
env:
PIP_SRC: ${{ runner.temp }}
run: |
pip install -e .

- name: Run Quality Tests
env:
TEST_SUITE: quality
SCRIPT_TO_RUN: ./scripts/generic-ci-tests.sh
PIP_SRC: ${{ runner.temp }}
TARGET_BRANCH: ${{ github.base_ref }}
run: |
./scripts/all-tests.sh

make test-lint
make test-eslint
make test-stylelint
make test-xsslint
make test-pi_check
make test-check_keyword

- name: Save Job Artifacts
if: always()
uses: actions/upload-artifact@v4
Expand Down
28 changes: 27 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
guides help lint-imports local-requirements migrate migrate-lms migrate-cms \
pre-requirements pull pull_xblock_translations pull_translations push_translations \
requirements shell swagger \
technical-docs test-requirements ubuntu-requirements upgrade-package upgrade
technical-docs test-requirements ubuntu-requirements upgrade-package upgrade pep8_test
salman2013 marked this conversation as resolved.
Show resolved Hide resolved

# Careful with mktemp syntax: it has to work on Mac and Ubuntu, which have differences.
PRIVATE_FILES := $(shell mktemp -u /tmp/private_files.XXXXXX)
Expand Down Expand Up @@ -204,3 +204,29 @@ migrate: migrate-lms migrate-cms
# Part of https://github.com/openedx/wg-developer-experience/issues/136
ubuntu-requirements: ## Install ubuntu 22.04 system packages needed for `pip install` to work on ubuntu.
sudo apt install libmysqlclient-dev libxmlsec1-dev

test-eslint:
python scripts/quality_test/quality_test.py eslint

test-stylelint:
python scripts/quality_test/quality_test.py stylelint

test-xsslint:
python scripts/quality_test/quality_test.py xsslint

test-lint:
pycodestyle .

test-pi_check:
python scripts/quality_test/quality_test.py pii_check

test-check_keyword:
python scripts/quality_test/quality_test.py check_keywords

test-js:
xvfb-run --auto-servernum python scripts/quality_test/js_test.py --option jstest
salman2013 marked this conversation as resolved.
Show resolved Hide resolved

test-coverage:
salman2013 marked this conversation as resolved.
Show resolved Hide resolved
python scripts/quality_test/js_test.py --option coverage

quality-test: test-lint test-eslint test-stylelint test-xsslint test-pi_check test-check_keyword
2 changes: 1 addition & 1 deletion pavelib/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
"""


from . import assets, js_test, prereqs, quality
from . import assets
143 changes: 0 additions & 143 deletions pavelib/js_test.py

This file was deleted.

22 changes: 0 additions & 22 deletions pavelib/paver_tests/conftest.py

This file was deleted.

Loading
Loading