feat: removing the application stage 2 #35186
Conversation
* removing the application folder * removing references in all other files FIXES: APER-3560
deborahgu
added
the
needs maintainer attention
removing an entire app. FIXES: APER-3560
actions need to know about changes to djangoapps FIXES: APER-3560
| @@ -474,28 +474,6 @@ def replace_usernames(self, username_mappings): | |||
| return self._request('POST', api_url, json=data) | |||
|
|
|||
|
|
|||
| class DemographicsApi(BaseApiClient): | |||
There was a problem hiding this comment.
This particular endpoint wasn't part of the Demographics app in edx-platform... wouldn't we still need to support retiring learners in the Demographics IDA itself?
I don't know enough about the inner workings of the retirement pipeline yet to know if it's using this particular piece of code. It appears that the DemographicsAPI is still part of the (forked) tubular repo in our GitHub org... so maybe we're okay removing this one?
Do you have a better understanding of the spaghetti?
There was a problem hiding this comment.
Aren't we about to retire the whole IDA, though? Does it matter if we miss a couple of retirement requests in the window before we delete all the data?
There was a problem hiding this comment.
on second thought, Justin is right, the DEPR of the IDA is soon but it's not imminent, better safe than sorry.
undoing a removal from the retirement pipeline that we aren't quite ready for yet FIXES: APER-3560
…s-django-app-from-edx-platform-pt2
deborahgu
deleted the
dkaplan1/APER-3560_depr-remove-demographics-django-app-from-edx-platform-pt2
branch
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This removes the deprecated demographics django application. No other apps in the repository currently reference this djangoapp in code or tables.
This DEPR was accepted in #35127. Only 2U ever used this app.
FIXES: APER-3560