feat: Update forum role membership api to DRF ( 11th ) #35343
Conversation
|
|
||
| if rolename not in [FORUM_ROLE_ADMINISTRATOR, FORUM_ROLE_MODERATOR, FORUM_ROLE_GROUP_MODERATOR, |
There was a problem hiding this comment.
Removed this line, now serializer will do all the validation.
awais786
changed the title
| has_instructor_access = has_access(request.user, 'instructor', course) | ||
| has_forum_admin = has_forum_access( | ||
| request.user, course_id, FORUM_ROLE_ADMINISTRATOR | ||
| ) |
There was a problem hiding this comment.
Is this a shortcoming of the permissions.InstructorPermission class? that we can't check these two and the above EDIT_FORUM_ROLES permissions at the same time for a user? Could we adapt the permission class to check for multiple roles or use a different one so that all the permissions checks happen as DRF permission checks?
There was a problem hiding this comment.
@feanil in separate API which is related with forums I have re-write the functionality.
Related [PR]
(#35366). I will merge 35366 first and then I will rebase this later.
has_instructor_access means user must be instructor.
has_forum_admin means user be added as Administrator in Django_Comment_Common > Roles.
Issues
Verify via postman
unique_student_identifier:usernamerolename: pass any from the list [Administrator,Moderator,Group Moderator,Community TA]action:alloworrevokeexpected result
{ "course_id": "course-v1:edx+cs222+2311", "action": "allow" }Verify via instructor dashboard
Discussion Moderators list.