feat: added notification grouping #35368
Open
+427
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhtishamShahid
force-pushed
the
inf-1472
branch
from
190bd05
to
da2348b
Compare
AhtishamShahid
requested review from
AhtishamShahid,
eemaanamir and
asadazam93
and removed request for
AhtishamShahid
|
Author pronouns are not working for both grouped and individual notifications. 
|
|
The following edge cases need to be handled:
|
AhtishamShahid
force-pushed
the
inf-1472
branch
from
9236459
to
57198fa
Compare
feat: added unit tests and refactored feat: added unit tests and refactored feat: added unit tests and refactored chore: removed extra file fix: resolved linter errors fix: resolved linter issues fix: resolved linter issues fix: resolved duplicate context issue fix: removed redundant method fix: resolved rendering issue fix: resolved linter issue fix: resolved author naming issue refactor: refactored code and fixed order in API fix: resolved linter issues
AhtishamShahid
force-pushed
the
inf-1472
branch
from
57198fa
to
aba5752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description :
Added grouping feature for new comment notifications
Ticket
https://2u-internal.atlassian.net/browse/INF-1472