-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Convert word cloud block sass variables to css variables #35386
Conversation
@farhan does the styling issue happen without your PR as well, or is it triggered by your PR? |
@kdmccormick Issue exists in the master branch, not triggered with my PR. |
As per decision with @kdmccormick let's merge this PR as issue is not triggered by this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we talked in our sync-up and decided that since the issue exists on master and since Farhan was able to confirm that the new css variable shows up in the DOM, that we do not to block this PR on a styling fix
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been rolled back from the edX production environment. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Ticket: #35306
Description:
Convert word cloud block sass variables to css variables
Other Relevant PR's:
#35233
#35385
How to test:
getComputedStyle(document.documentElement).getPropertyValue('--baseline')
Pending/Known Issue:
5px or appropriate value of margin should be reflected in the styling of word-cloud xblock unit frame but it's not.
I think the issue is
.xmodule_display.xmodule_WordCloudBlock
class doesn't exist referred in the generatd css file given below (css generated on themaster
branch for the testing)