temp: empty commit to allow PR creation, so we can create a sandbox for testing #35416

pomegranited · 2024-09-03T05:29:10Z

Description

This PR was created to create a sandbox for a UI/UX review of forum notifications.

It can be closed when this testing is complete.

Supporting information

Related issue:

Improving forum notifications for users and teachers platform-roadmap#274

Settings

TUTOR_GROVE_LMS_ENV: |
  COURSE_CATALOG_URL_ROOT:  'https://discovery.pr-35416-0e7f8a.sandboxes.opencraft.hosting'
  COURSE_CATALOG_API_URL: 'https://discovery.pr-35416-0e7f8a.sandboxes.opencraft.hosting/api/v1'
  LOCAL_LOGLEVEL: "DEBUG"
TUTOR_GROVE_CMS_ENV: |
  COURSE_CATALOG_URL_ROOT: 'https://discovery.pr-35416-0e7f8a.sandboxes.opencraft.hosting'
  COURSE_CATALOG_API_URL: 'https://discovery.pr-35416-0e7f8a.sandboxes.opencraft.hosting/api/v1'

openedx-webhooks · 2024-09-03T05:29:14Z

Thanks for the pull request, @pomegranited!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

open-craft-grove · 2024-09-03T10:40:56Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-09-03T10:56:30Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

pomegranited · 2024-09-03T23:09:09Z

Hi @felipemontoya , sorry to ping you directly! But I'm trying to set up a sandbox that showcases the Notifications feature, and I'm having trouble finding it in the latest code.

I found this PR which removed it from the openedx header: feat: deprecate notification tray in learning header frontend-component-header#379
It says there's a plan to extract it to an npm package, but I can't find any notification-related frontend components in org:openedx or org:edx that I can plug in.
There's code for it in the edX header: https://github.com/search?q=repo%3Aedx%2Ffrontend-component-header-edx%20notification&type=code
The backend code is still happy in edx-platform, and I've enabled all the waffle flags I can find.

Do you know where this feature lives now? Or can you point me towards someone who might?

felipemontoya · 2024-09-03T23:48:42Z

I think it lives in the learning mfe now.

https://github.com/openedx/frontend-app-learning/tree/391726249233c848e91047894232aa9e386b8eef/src/courseware/course/sidebar/sidebars/notifications

In case this is interesting to you, for the Spanish project we ended up creating a platform plugin to handle email notifications.
https://github.com/eduNEXT/platform-plugin-forum-email-notifier/

pomegranited · 2024-09-04T05:34:22Z

Oh fantastic, thank you @felipemontoya !

pomegranited · 2024-09-10T06:56:42Z

FYI, I get errors from the notifications if there's no course discovery service running 🤦

open-craft-grove · 2024-09-10T07:36:52Z