-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: component asset api views #35765
fix: component asset api views #35765
Conversation
Thanks for the pull request, @navinkarkera! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
7f08c15
to
0664326
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Perfect fix, thank you @navinkarkera !
- I tested this by:
- Logged out completely from the LMS + CMS.
- Logged into the Authoring MFE (via the LMS)
- Viewed a draft Text component with an uploaded image in its HTML source in the component preview -- was able to view the draft image without error.
- Viewed a published Text component with an image from the Library Content (beta) component picker -- was able to view the published image without error.
- Reverted my platform code back to
master
and retried 3 & 4 above: no longer able to see these images; confirmed 403 errors in CMS logs
- I read through the code
-
I checked for accessibility issues by using my keyboard to navigateN/A - Includes documentation -- code comments updated
-
User-facing strings are extracted for translationN/A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work, @navinkarkera!
- I tested this using the instructions from the PR
- I read through the code
-
I checked for accessibility issuesN/A - Includes documentation
0664326
to
e7cf378
Compare
Uses drf view to authenticate user before allowing them to access library static assets. (cherry picked from commit ca7da37)
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Uses drf view to authenticate user before allowing them to access library static assets. (cherry picked from commit ca7da37)
Uses drf view to authenticate user before allowing them to access library static assets. (cherry picked from commit ca7da37)
Description
Fix for: openedx/frontend-app-authoring#1434
Supporting information
Private-ref
: FAL-3933Testing instructions
Follow steps to reproduce issue given in openedx/frontend-app-authoring#1434 without the changes in this PR and try again to see if it is fixed with this PR.
You need to set
OPENEDX_LEARNING
setting locally to get image upload working.