Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: component asset api views #35765

Merged

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Nov 4, 2024

Description

Fix for: openedx/frontend-app-authoring#1434

Supporting information

Testing instructions

Follow steps to reproduce issue given in openedx/frontend-app-authoring#1434 without the changes in this PR and try again to see if it is fixed with this PR.

You need to set OPENEDX_LEARNING setting locally to get image upload working.

OPENEDX_LEARNING = {'MEDIA':{
    'BACKEND':'django.core.files.storage.FileSystemStorage',
    'OPTIONS':{'location':MEDIA_ROOT+'_private'}
}}

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 4, 2024

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 4, 2024
@navinkarkera navinkarkera marked this pull request as ready for review November 5, 2024 07:10
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Perfect fix, thank you @navinkarkera !

  • I tested this by:
    1. Logged out completely from the LMS + CMS.
    2. Logged into the Authoring MFE (via the LMS)
    3. Viewed a draft Text component with an uploaded image in its HTML source in the component preview -- was able to view the draft image without error.
    4. Viewed a published Text component with an image from the Library Content (beta) component picker -- was able to view the published image without error.
    5. Reverted my platform code back to master and retried 3 & 4 above: no longer able to see these images; confirmed 403 errors in CMS logs
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate N/A
  • Includes documentation -- code comments updated
  • User-facing strings are extracted for translation N/A

Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @navinkarkera!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation

@navinkarkera navinkarkera merged commit ca7da37 into openedx:master Nov 7, 2024
49 checks passed
@navinkarkera navinkarkera deleted the navin/fix-static-asset-access branch November 7, 2024 13:57
navinkarkera added a commit to open-craft/edx-platform that referenced this pull request Nov 7, 2024
Uses drf view to authenticate user before allowing them to access library static assets.

(cherry picked from commit ca7da37)
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

navinkarkera added a commit to open-craft/edx-platform that referenced this pull request Nov 8, 2024
Uses drf view to authenticate user before allowing them to access library static assets.

(cherry picked from commit ca7da37)
navinkarkera added a commit to open-craft/edx-platform that referenced this pull request Nov 8, 2024
Uses drf view to authenticate user before allowing them to access library static assets.

(cherry picked from commit ca7da37)
navinkarkera added a commit that referenced this pull request Nov 8, 2024
Uses drf view to authenticate user before allowing them to access library static assets.

(cherry picked from commit ca7da37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants