Merge pull request #480 from edx/matthugs/non-js-provider-error-state…

…-bug Fix bug wherein non-JS proctoring providers attempt to ping
openedx · Dec 10, 2018 · 06131ca · 06131ca
2 parents 15a02d8 + 04c337f
commit 06131ca
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/edx_proctoring/static/proctoring/js/views/proctored_exam_view.js b/edx_proctoring/static/proctoring/js/views/proctored_exam_view.js
@@ -144,8 +144,11 @@ var edx = edx || {};
         updateRemainingTime: function (self) {
             self.timerTick ++;
             self.secondsLeft --;
-            if (self.timerTick % self.poll_interval === self.poll_interval / 2) {
-              edx.courseware.proctored_exam.pingApplication().catch(self.endExamForFailureState.bind(self));
+            if (
+                self.timerTick % self.poll_interval === self.poll_interval / 2 &&
+                edx.courseware.proctored_exam.configuredWorkerURL
+            ) {
+                edx.courseware.proctored_exam.pingApplication().catch(self.endExamForFailureState.bind(self));
             }
             if (self.timerTick % self.poll_interval === 0) {
                 var url = self.model.url + '/' + self.model.get('attempt_id');

diff --git a/edx_proctoring/static/proctoring/spec/proctored_exam_spec.js b/edx_proctoring/static/proctoring/spec/proctored_exam_spec.js
@@ -97,10 +97,12 @@ describe('ProctoredExamView', function () {
     });
     it("calls external js global function on off-beat", function() {
         edx.courseware.proctored_exam.pingApplication = jasmine.createSpy().and.returnValue(Promise.resolve());
+        edx.courseware.proctored_exam.configuredWorkerURL = 'nonempty/string.html';
         this.proctored_exam_view.timerTick = this.proctored_exam_view.poll_interval / 2 - 1;
         this.proctored_exam_view.updateRemainingTime(this.proctored_exam_view);
         expect(edx.courseware.proctored_exam.pingApplication).toHaveBeenCalled();
-        delete edx.courseware.proctored_exam.pingApplication
+        delete edx.courseware.proctored_exam.pingApplication;
+        delete edx.courseware.proctored_exam.configuredWorkerURL;
     });
     it("reloads the page after failure-state ajax call", function(done) {
         this.server.respondWith(