Merge pull request #825 from edx/bseverino/ping-interval-setting

[MST-744] Change ping interval to a Django setting
openedx · Apr 5, 2021 · 71b3aca · 71b3aca
2 parents 425499e + 872434b
commit 71b3aca
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -14,6 +14,10 @@ Change Log
 Unreleased
 ~~~~~~~~~~
 
+[3.8.2] - 2021-04-02
+~~~~~~~~~~~~~~~~~~~~~
+* Update `DEFAULT_DESKTOP_APPLICATION_PING_INTERVAL_SECONDS` to pull from settings.
+
 [3.8.1] - 2021-04-01
 ~~~~~~~~~~~~~~~~~~~~~
 * Increase ping interval from 30 to 60 seconds.

diff --git a/edx_proctoring/__init__.py b/edx_proctoring/__init__.py
@@ -3,6 +3,6 @@
 """
 
 # Be sure to update the version number in edx_proctoring/package.json
-__version__ = '3.8.1'
+__version__ = '3.8.2'
 
 default_app_config = 'edx_proctoring.apps.EdxProctoringConfig'  # pylint: disable=invalid-name
diff --git a/edx_proctoring/constants.py b/edx_proctoring/constants.py
@@ -56,8 +56,12 @@
     else getattr(settings, 'SOFTWARE_SECURE_SHUT_DOWN_GRACEPERIOD', 10)
 )
 
-MINIMUM_TIME = datetime.datetime.fromtimestamp(0)
+DEFAULT_DESKTOP_APPLICATION_PING_INTERVAL_SECONDS = (
+    settings.PROCTORING_SETTINGS['DESKTOP_APPLICATION_PING_INTERVAL_SECONDS'] if
+    'DESKTOP_APPLICATION_PING_INTERVAL_SECONDS' in settings.PROCTORING_SETTINGS
+    else getattr(settings, 'DESKTOP_APPLICATION_PING_INTERVAL_SECONDS', 60)
+)
 
-DEFAULT_DESKTOP_APPLICATION_PING_INTERVAL_SECONDS = 60
+MINIMUM_TIME = datetime.datetime.fromtimestamp(0)
 
 PING_FAILURE_PASSTHROUGH_TEMPLATE = 'edx_proctoring.{}_ping_failure_passthrough'
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "@edx/edx-proctoring",
   "//": "Be sure to update the version number in edx_proctoring/__init__.py",
   "//": "Note that the version format is slightly different than that of the Python version when using prereleases.",
-  "version": "3.8.1",
+  "version": "3.8.2",
   "main": "edx_proctoring/static/index.js",
   "scripts":{
     "test":"gulp test"