Skip to content

Commit

Permalink
fix: unreference the ProctoredExamSoftwareSecureReview.video_url (#989)
Browse files Browse the repository at this point in the history
No longer have anywhere in the code to reference video_url of the ProctoredExamSoftwareSecureReview model. Set it to be removed from the model

Co-authored-by: Simon Chen <[email protected]>
  • Loading branch information
schenedx and Simon Chen authored Oct 29, 2021
1 parent edea764 commit c74e120
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 13 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ Change Log
Unreleased
~~~~~~~~~~
[4.3.2] - 2021-10-28
~~~~~~~~~~~~~~~~~~~~
* Remove video_url reference from ProctoredExamSoftwareSecureReview.

[4.3.1] - 2021-10-28
~~~~~~~~~~~~~~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion edx_proctoring/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"""

# Be sure to update the version number in edx_proctoring/package.json
__version__ = '4.3.1'
__version__ = '4.3.2'

default_app_config = 'edx_proctoring.apps.EdxProctoringConfig' # pylint: disable=invalid-name
8 changes: 0 additions & 8 deletions edx_proctoring/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -771,11 +771,6 @@ class ProctoredExamSoftwareSecureReview(TimeStampedModel):
# reviewing service
raw_data = models.TextField()

# URL for the exam video that had been reviewed
# NOTE: To be deleted in future release, once the code that depends on it
# has been removed
video_url = models.TextField(null=True)

# Encrypted URL for the exam video that had been reviewed
encrypted_video_url = models.BinaryField(null=True)

Expand Down Expand Up @@ -849,9 +844,6 @@ class ProctoredExamSoftwareSecureReviewHistory(TimeStampedModel):
# reviewing service
raw_data = models.TextField()

# URL for the exam video that had been reviewed
video_url = models.TextField(null=True)

# user_id of person who did the review (can be None if submitted via server-to-server API)
reviewed_by = models.ForeignKey(USER_MODEL, null=True, related_name='+', on_delete=models.CASCADE)

Expand Down
3 changes: 0 additions & 3 deletions edx_proctoring/tests/test_reviews.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ def test_psi_review_callback(self, psi_review_status, review_status, credit_requ

self.assertIsNotNone(review)
self.assertEqual(review.review_status, review_status)
self.assertFalse(review.video_url)
self.assertTrue(review.encrypted_video_url)

self.assertIsNotNone(review.raw_data)
Expand Down Expand Up @@ -301,7 +300,6 @@ def test_review_on_archived_attempt(self):

self.assertIsNotNone(review)
self.assertEqual(review.review_status, SoftwareSecureReviewStatus.clean)
self.assertFalse(review.video_url)

self.assertIsNotNone(review.raw_data)

Expand Down Expand Up @@ -347,7 +345,6 @@ def test_allow_review_resubmission(self):

self.assertIsNotNone(review)
self.assertEqual(review.review_status, SoftwareSecureReviewStatus.suspicious)
self.assertFalse(review.video_url)

self.assertIsNotNone(review.raw_data)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@edx/edx-proctoring",
"//": "Note that the version format is slightly different than that of the Python version when using prereleases.",
"version": "4.3.1",
"version": "4.3.2",
"main": "edx_proctoring/static/index.js",
"scripts": {
"test": "gulp test"
Expand Down

0 comments on commit c74e120

Please sign in to comment.