Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds backoff to enterprise-catalog client calls #547

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Aug 27, 2024

Adds backoff decorator to the enterprise access api client functions as a means to retry calls that may face connection or timeout errors.

I opted for a conservative amount of retries (3) given the exponential nature of the wait_gen or backoff strategy and contains_content_items usage in the can-redeem function.

Description:
Add a description of your changes here.

Jira:
ENT-XXXX

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@brobro10000 brobro10000 force-pushed the hu/ent-9081 branch 3 times, most recently from 7c5bf6c to 55b815c Compare August 27, 2024 14:31
@brobro10000 brobro10000 force-pushed the hu/ent-9081 branch 3 times, most recently from c44bc5e to 5219ea6 Compare August 27, 2024 15:06
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but I might also defer to a review from someone (e.g.,. Troy?) more familiar with best practices around implementation of this backoff strategy.

@brobro10000 brobro10000 merged commit 8fbda7f into main Sep 3, 2024
3 checks passed
@brobro10000 brobro10000 deleted the hu/ent-9081 branch September 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants