feat: add fields parent_content_key and is_assigned_course_run for assignments #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
force-pushed
the
ags/ent-8876
branch
2 times, most recently
from
c04bfd5
to
467ff12
Compare
adamstankiewicz
commented
Sep 3, 2024
Comment on lines
+34
to
+38
| migrations.AlterField( | ||
| model_name='historicallearnercontentassignment', | ||
| name='allocated_at', | ||
| field=models.DateTimeField(blank=True, default=django.utils.timezone.now, help_text='The last time the assignment was allocated. Cannot be null.'), | ||
| ), |
There was a problem hiding this comment.
[inform] This migration is unrelated to changes I made in this PR; seems like it's a migration that was missing (i.e., auto-generated during makemigrations).
adamstankiewicz
force-pushed
the
ags/ent-8876
branch
from
467ff12
to
1020939
Compare
adamstankiewicz
commented
Sep 3, 2024
| preferred_course_run_key = _get_preferred_course_run_key(assignment_configuration, content_key) | ||
| is_assigned_course_run = bool(parent_content_key) |
There was a problem hiding this comment.
[inform] Uses a non-null parent_content_key to determine whether the assignment is run-based.
iloveagent57
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
LearnerContentAssignment:parent_content_key. This will represent a top-level course key when the assignment'scontent_keyis a course run. Otherwise,None.is_assigned_course_run. This will indicate whether the assignment is course run-based or course-based.parent_content_keyandis_assigned_course_runin API responses.is_assigned_course_runas a read-only field in Django Admin._get_parent_content_keyto return either a course run's parent course'scontent_keyorNoneif the providedcontent_keyis already a course run.parent_content_keyandis_assigned_course_runduring assignment object creation.Jira:
ENT-8876
Merge checklist:
./manage.py makemigrationshas been runPost merge: