Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use utility from openedex_events to reset application … #56

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Oct 16, 2023

Description: Uses utility from openedx_events implemented in openedx/openedx-events#277 to reset application state

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 16, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 16, 2023

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

requirements/base.in Outdated Show resolved Hide resolved
@navinkarkera navinkarkera changed the title wip: refactor: use utility from openedex_events to reset application … refactor: use utility from openedex_events to reset application … Oct 16, 2023
@mphilbrick211
Copy link

hi @navinkarkera! Just checking in on this one :)

@navinkarkera navinkarkera marked this pull request as ready for review February 9, 2024 07:13
@navinkarkera
Copy link
Contributor Author

@mphilbrick211 Sorry for the long silence. This is now ready.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for getting it over the line

@robrap
Copy link

robrap commented Feb 9, 2024

Thanks for keeping me in the loop.

@bmtcril bmtcril merged commit 8d7a182 into openedx:main Feb 14, 2024
9 checks passed
@openedx-webhooks
Copy link

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants