Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mark signals as already emitted by event bus #76

Closed
wants to merge 1 commit into from
Closed

fix: mark signals as already emitted by event bus #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion edx_event_bus_redis/internal/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ def emit_signals_from_message(self, msg: RedisMessage):

signal = OpenEdxPublicSignal.get_signal_by_type(msg.event_metadata.event_type)
event_data = deserialize_bytes_to_event_data(msg.event_data, signal)
send_results = signal.send_event_with_custom_metadata(msg.event_metadata, **event_data)
send_results = signal.send_event_with_custom_metadata(msg.event_metadata, **event_data, from_event_bus=True)
# Raise an exception if any receivers errored out. This allows logging of the receivers
# along with partition, offset, etc. in record_event_consuming_error. Hopefully the
# receiver code is idempotent and we can just replay any messages that were involved.
Expand Down
Loading