fix: catch null weighted_possible

openedx · Aug 3, 2023 · d7121d4 · d7121d4
1 parent 71d364a
commit d7121d4
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/event_routing_backends/processors/xapi/event_transformers/problem_interaction_events.py b/event_routing_backends/processors/xapi/event_transformers/problem_interaction_events.py
@@ -151,16 +151,22 @@ def get_result(self):
             `Result`
         """
         event_data = self.get_data('data')
-        if event_data['weighted_possible'] > 0:
-            scaled = event_data['weighted_earned']/event_data['weighted_possible']
+        weighted_possible = event_data['weighted_possible']
+        weighted_earned = event_data['weighted_earned']
+
+        if weighted_possible is None:
+            weighted_possible = 0
+
+        if weighted_possible > 0:
+            scaled = weighted_earned/weighted_possible
         else:
             scaled = 0
         return Result(
-            success=event_data['weighted_earned'] >= event_data['weighted_possible'],
+            success=weighted_earned >= weighted_possible,
             score={
                 'min': 0,
-                'max': event_data['weighted_possible'],
-                'raw': event_data['weighted_earned'],
+                'max': weighted_possible,
+                'raw': weighted_earned,
                 'scaled': scaled
             }
         )