chore: quality fixes

openedx · Mar 21, 2024 · f8a1415 · f8a1415
1 parent d64d1da
commit f8a1415
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/event_routing_backends/management/commands/recover_failed_events.py b/event_routing_backends/management/commands/recover_failed_events.py
@@ -9,6 +9,7 @@
 from django.core.management.base import BaseCommand
 from eventtracking.backends.event_bus import EventBusRoutingBackend
 from eventtracking.tracker import get_tracker
+
 from event_routing_backends.processors.transformer_utils.exceptions import EventNotDispatched
 
 logger = logging.getLogger(__name__)
@@ -67,16 +68,20 @@ def handle(self, *args, **options):
                 logger.info("Skipping backend: {}".format(name))
                 continue
             for backend_name, backend in engine.backends.items():
-                while failed_events:=backend.get_failed_events(batch_size):
-                    logger.info("Recovering {} failed events for backend {}".format(len(failed_events), backend_name))
+                while failed_events := backend.get_failed_events(batch_size):
+                    logger.info(
+                        "Recovering {} failed events for backend {}".format(
+                            len(failed_events), backend_name
+                        )
+                    )
                     for event in failed_events:
                         try:
                             backend.send(event)
                             success += 1
-                        except EventNotDispatched as e:
+                        except EventNotDispatched:
                             logger.error("Malformed event: {}".format(event["name"]))
                             malformed += 1
-                        except Exception as e:
+                        except Exception as e:  # pylint: disable=broad-except
                             # Backend can still be in a bad state, so we need to catch all exceptions
                             logger.error("Failed to send event: {}".format(e))
                             failed += 1

diff --git a/event_routing_backends/management/commands/tests/test_recover_failed_events.py b/event_routing_backends/management/commands/tests/test_recover_failed_events.py
@@ -8,6 +8,7 @@
 from django.test import TestCase
 from django.test.utils import override_settings
 from eventtracking.django.django_tracker import DjangoTracker
+
 from event_routing_backends.processors.transformer_utils.exceptions import EventNotDispatched
 
 XAPI_PROCESSOR = {
@@ -81,7 +82,9 @@ def test_send_tracking_log_to_backends(self, mock_get_tracker):
         "event_routing_backends.management.commands.recover_failed_events.get_tracker"
     )
     @patch("event_routing_backends.management.commands.recover_failed_events.logger")
-    def test_send_tracking_log_to_backends_with_exception(self, mock_logger, mock_get_tracker):
+    def test_send_tracking_log_to_backends_with_exception(
+        self, mock_logger, mock_get_tracker
+    ):
         """
         Test for send_tracking_log_to_backends
         """
@@ -94,7 +97,6 @@ def test_send_tracking_log_to_backends_with_exception(self, mock_logger, mock_ge
 
         call_command("recover_failed_events", transformer_type="all")
 
-        #mock_logger.error.assert_called_once_with("Malformed event: {}".format("test"))
         mock_logger.error.assert_called_once_with("Failed to send event: Error")
 
     @override_settings(
@@ -111,7 +113,9 @@ def test_send_tracking_log_to_backends_with_exception(self, mock_logger, mock_ge
         "event_routing_backends.management.commands.recover_failed_events.get_tracker"
     )
     @patch("event_routing_backends.management.commands.recover_failed_events.logger")
-    def test_send_tracking_log_to_backends_with_event_exception(self, mock_logger, mock_get_tracker):
+    def test_send_tracking_log_to_backends_with_event_exception(
+        self, mock_logger, mock_get_tracker
+    ):
         """
         Test for send_tracking_log_to_backends
         """