Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Divide by 0 errors on problem interaction events #322

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Jul 19, 2023

Description: Some fields in the wild have unexpected 0 values, leading to "divide by 0" errors on transform. This PR handles them somewhat more elegantly.

Closes: #311

@bmtcril bmtcril requested a review from ziafazal July 19, 2023 14:43
@bmtcril bmtcril force-pushed the bmtcril/fix_interaction_events branch from 5914551 to f5987fc Compare July 25, 2023 18:35
Copy link
Contributor

@Ian2012 Ian2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmtcril
Copy link
Contributor Author

bmtcril commented Jul 27, 2023

@ziafazal can you take a peek when you have a sec? @pomegranited heads up on this one too.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmtcril bmtcril merged commit 71d364a into master Jul 31, 2023
@bmtcril bmtcril deleted the bmtcril/fix_interaction_events branch July 31, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Replaying problem interaction events
4 participants