Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: python 3.11 and 3.12 support #404

Merged
merged 3 commits into from
May 17, 2024
Merged

build: python 3.11 and 3.12 support #404

merged 3 commits into from
May 17, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Mar 22, 2024

Description: Describe in a couple of sentences what this PR adds

JIRA: Link to JIRA ticket

Dependencies: dependencies on other outstanding PRs, issues, etc.

Merge deadline: List merge deadline (if any)

Installation instructions: List any non-trivial installation
instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@openedx-webhooks
Copy link

openedx-webhooks commented Mar 22, 2024 •
edited
Loading

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 22, 2024
@Ian2012 Ian2012 marked this pull request as ready for review March 22, 2024 20:13
@Ian2012
Copy link
Contributor Author

Ian2012 commented Mar 22, 2024 •
edited
Loading

Hi @awais786. Is this enough for the upgrade or do we need something else?

ziafazal
ziafazal approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

event_routing_backends/backends/tests/test_events_router.py Outdated Show resolved Hide resolved
@awais786 awais786 closed this Mar 25, 2024
@awais786 awais786 reopened this Mar 25, 2024
awais786
awais786 reviewed Apr 1, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Ian2012 Ian2012 force-pushed the cag/python-support branch 2 times, most recently from c714e26 to e510525 Compare April 1, 2024 16:24
@Ian2012
Copy link
Contributor Author

Ian2012 commented Apr 1, 2024

@ziafazal @awais786, do any of you know how to remove the django32 check hanging out?

@Ian2012 Ian2012 force-pushed the cag/python-support branch 2 times, most recently from af8c7a9 to 73700eb Compare April 1, 2024 19:00
@awais786
Copy link
Contributor

awais786 commented Apr 1, 2024

@feanil Please review and merge. It has django32 required check which need to be remove.

@Ian2012
Copy link
Contributor Author

Ian2012 commented May 17, 2024

@feanil just a friendly reminder that is pending.

feanil
feanil approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added a version bump so you can release this after it's merged.

awais786 and others added 2 commits May 17, 2024 09:10
@awais786 @feanil
build: python 3.11 and 3.12 support.
4971621 
build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

chore: Updating Python Requirements (#396)

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

build: python 3.11 and 3.12 support.

fix: include setuptools in quality requirements

chore: quality fixes
@feanil
build: Bump the version so that we can release a new version.
6453cd8
@feanil
build: Add tox rules and update ci matrix.
eb801db 
Tox did not have the other python versions so we couldn't test locally
with those easily.  Also, we don't need to run the `docs`, `quality` and
`pii_check` on all versions. Running it on the latest version is
sufficient.
@feanil
Copy link
Contributor

feanil commented May 17, 2024

@ziafazal I'm gonna merge and release but in the future, please feel free to do that on this repo as the maintainer.

@feanil feanil merged commit 8328a10 into master May 17, 2024
11 checks passed
@feanil feanil deleted the cag/python-support branch May 17, 2024 13:40
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awais786 awais786 awais786 left review comments

@feanil feanil feanil approved these changes

@ziafazal ziafazal ziafazal approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ian2012 @openedx-webhooks @awais786 @feanil @ziafazal