Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use whitelisted events to identify known_events #426

Closed
wants to merge 2 commits into from
Closed

fix: use whitelisted events to identify known_events #426

wants to merge 2 commits into from

Conversation

saraburns1
Copy link
Contributor

@saraburns1 saraburns1 commented Jun 4, 2024

updated version of #425

Description:
Allow new 'whitelist' option OR legacy 'registry.mapping' option for list of events
Update unit tests to check both

Testing
Ran all new and existing tests - no failures

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

@saraburns1 saraburns1 marked this pull request as ready for review June 5, 2024 15:29
@saraburns1 saraburns1 changed the title fix: change setting, fix typo in test log fix: use whitelisted events to identify known_events Jun 5, 2024
@saraburns1 saraburns1 closed this Jun 5, 2024
@saraburns1 saraburns1 reopened this Jun 5, 2024
@saraburns1 saraburns1 closed this Jun 5, 2024
@saraburns1 saraburns1 reopened this Jun 5, 2024
@saraburns1 saraburns1 closed this Jun 5, 2024
@saraburns1 saraburns1 reopened this Jun 5, 2024
@saraburns1 saraburns1 closed this Jun 5, 2024
@saraburns1 saraburns1 reopened this Jun 5, 2024
@saraburns1 saraburns1 requested a review from bmtcril June 5, 2024 19:17
@saraburns1 saraburns1 closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant