Skip to content

Commit

Permalink
chore: PR feedback 3
Browse files Browse the repository at this point in the history
  • Loading branch information
brobro10000 committed Sep 12, 2024
1 parent 7ec4892 commit 201ce8b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ import PropTypes from 'prop-types';

import dayjs from 'dayjs';
import {
getNormalizedEnrollByDate, getNormalizedStartDate, hasCourseStarted, SHORT_MONTH_DATE_FORMAT,
DATETIME_FORMAT,
getNormalizedEnrollByDate,
getNormalizedStartDate,
hasCourseStarted,
SHORT_MONTH_DATE_FORMAT,
} from '../data';

const messages = defineMessages({
Expand Down Expand Up @@ -51,7 +55,7 @@ const AssignmentModalImportantDates = ({ courseRun }) => {
const intl = useIntl();
const normalizedEnrollByDate = getNormalizedEnrollByDate(courseRun);
const enrollByDate = normalizedEnrollByDate
? dayjs(normalizedEnrollByDate).format(SHORT_MONTH_DATE_FORMAT)
? dayjs(normalizedEnrollByDate).format(DATETIME_FORMAT)
: null;
const courseStartDate = getNormalizedStartDate(courseRun);
const courseHasStartedLabel = hasCourseStarted(courseStartDate)
Expand Down
1 change: 1 addition & 0 deletions src/components/learner-credit-management/data/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export const NO_BALANCE_REMAINING_DOLLAR_THRESHOLD = 100;
export const DATE_FORMAT = 'MMMM DD, YYYY';

export const SHORT_MONTH_DATE_FORMAT = 'MMM DD, YYYY';
export const DATETIME_FORMAT = 'MMM D, YYYY h:mma';

export const EXEC_ED_OFFER_TYPE = 'learner_credit';

Expand Down

0 comments on commit 201ce8b

Please sign in to comment.