fix: memoized the course run ids passed to useApplicableCatalogs (#1296)

* fix: memoized the course run ids passed to useApplicableCatalogs * fix: same fix for coupon requests
openedx · Sep 9, 2024 · f28dc42 · f28dc42
1 parent 1957eff
commit f28dc42
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/components/subsidy-request-modals/ApproveCouponCodeRequestModal.jsx b/src/components/subsidy-request-modals/ApproveCouponCodeRequestModal.jsx
@@ -28,13 +28,14 @@ export const ApproveCouponCodeRequestModal = ({
   onSuccess,
   onClose,
 }) => {
+  const courseRunIds = useMemo(() => [courseId], [courseId]);
   const {
     applicableCoupons,
     isLoading: isLoadingApplicableCoupons,
     error: loadApplicableCouponsError,
   } = useApplicableCoupons({
     enterpriseId: enterpriseCustomerUUID,
-    courseRunIds: [courseId],
+    courseRunIds,
     coupons,
   });
   const [selectedCouponId, setSelectedCouponId] = useState();

diff --git a/src/components/subsidy-request-modals/ApproveLicenseRequestModal.jsx b/src/components/subsidy-request-modals/ApproveLicenseRequestModal.jsx
@@ -28,13 +28,14 @@ export const ApproveLicenseRequestModal = ({
   onClose,
 }) => {
   const { data: subscriptions } = useContext(SubscriptionContext);
+  const courseRunIds = useMemo(() => [courseId], [courseId]);
   const {
     applicableSubscriptions,
     isLoading: isLoadingApplicableSubscriptions,
     error: loadApplicableSubscriptionsError,
   } = useApplicableSubscriptions({
     enterpriseId: enterpriseCustomerUUID,
-    courseRunIds: [courseId],
+    courseRunIds,
     subscriptions,
   });
 
@@ -92,7 +93,7 @@ export const ApproveLicenseRequestModal = ({
           defaultMessage="Approve License Request"
           description="Title for the approve license request modal."
         />
-)}
+      )}
       isOpen={isOpen}
       hasCloseButton
       onClose={onClose}