Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing max num of highlights #1306

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix: changing max num of highlights #1306

merged 2 commits into from
Sep 16, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Sep 16, 2024

Changing the maximum number of highlights allowed
Associated PRs in enterprise-catalog and frontend-app-learner-portal
Jira ticket

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (671ce54) to head (4309c59).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1306   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files         566      566           
  Lines       12467    12467           
  Branches     2641     2643    +2     
=======================================
  Hits        10672    10672           
  Misses       1736     1736           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pmakwana93 pmakwana93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiram15 kiram15 merged commit d1a270f into master Sep 16, 2024
7 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9493 branch September 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants