Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing number of max highlights allowed #1185

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Sep 16, 2024

Changing the maximum number of highlights allowed
Associated PRs in openedx/frontend-app-admin-portal#1306 and enterprise-catalog
Jira ticket

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (0d978d2) to head (6f554d8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
+ Coverage   88.36%   88.40%   +0.04%     
==========================================
  Files         396      396              
  Lines        8406     8392      -14     
  Branches     2025     2056      +31     
==========================================
- Hits         7428     7419       -9     
+ Misses        936      931       -5     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pmakwana93 pmakwana93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiram15 kiram15 merged commit 4c45493 into master Sep 16, 2024
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9493 branch September 16, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants