-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-7512: LearnerCreditAllocationTable course title #1025
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrosarioa
changed the title
ENT-7512: LearnerPortalAllocationTable course title
ENT-7512: LearnerCreditAllocationTable course title
Aug 31, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
=======================================
Coverage 82.88% 82.88%
=======================================
Files 401 401
Lines 8727 8731 +4
Branches 1800 1803 +3
=======================================
+ Hits 7233 7237 +4
Misses 1455 1455
Partials 39 39
☔ View full report in Codecov by Sentry. |
adamstankiewicz
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user of the admin portal does not have the learner portal enabled, the course title in the LearnerCreditAllocationTable "Enrollment details" column should be a string and not a link that would result in a 404.
Table when user does have learner portal enabled, with course title as links:
Table when user does not have learner portal enabled, with course titles as strings:
For all changes
Only if submitting a visual change