Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update max allowed highlights per set and max number of highlight sets #1033

Merged
merged 2 commits into from
Sep 18, 2023
Merged

chore: update max allowed highlights per set and max number of highlight sets #1033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb38ec1
chore: update max allowed highlights per set and max number of highli…
macdiesel Sep 18, 2023
1f05ceb
Merge branch 'master' into bbeggs/increase_max_highlights
macdiesel Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/ContentHighlights/data/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ export const TAB_TITLES = {
export const MAX_HIGHLIGHT_TITLE_LENGTH = 60;

// Max highlight sets per enteprise curation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: while we're in here, typo in enteprise above ;)

export const MAX_HIGHLIGHT_SETS_PER_ENTERPRISE_CURATION = 8;
export const MAX_HIGHLIGHT_SETS_PER_ENTERPRISE_CURATION = 12;

// Max number of content items per highlight set
export const MAX_CONTENT_ITEMS_PER_HIGHLIGHT_SET = 12;
export const MAX_CONTENT_ITEMS_PER_HIGHLIGHT_SET = 24;

// Max number of content items displayed from search results
export const MAX_PAGE_SIZE = 24;
Expand Down