-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show all enterprise budgets regardless of plan and route correctly #1037
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## eahmadjaved/ENT-7660 #1037 +/- ##
========================================================
+ Coverage 82.90% 82.91% +0.01%
========================================================
Files 412 415 +3
Lines 8902 8933 +31
Branches 1825 1832 +7
========================================================
+ Hits 7380 7407 +27
- Misses 1482 1484 +2
- Partials 40 42 +2
☔ View full report in Codecov by Sentry. |
a2f8142
to
5aecd8f
Compare
73e3e4b
to
ac6f555
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/components/learner-credit-management/LearnerCreditManagementRoutes.jsx
Outdated
Show resolved
Hide resolved
ac6f555
to
aeaf98f
Compare
7db485e
to
d53064d
Compare
991e85b
to
7d87d7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamstankiewicz if this PR looks good to you, then please approve this.
7d87d7d
to
b1e17cb
Compare
@jajjibhai008 I'm seeing a couple, possibly related, prop type warnings when running this PR locally. Do you mind verifying to ensure they are either unrelated to your changes or, if they are related, whether they can be addressed?
|
e719476
to
0398253
Compare
|
src/components/learner-credit-management/MultipleBudgetsPicker.jsx
Outdated
Show resolved
Hide resolved
0398253
to
84be93a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the work on this :)
b866982
to
f53b2d9
Compare
fix: full page refresh issue when clicking 'Budgets', added test coverage and fixed lint issues feat: show all enterprise budgets regardless of plan and route correctly fix: moved LCM routes to separate file fix: resolve spacing and repetitions issue fix: resolve spacing and repetitions issue fix: improved test coverage refactor: improve code efficiency and readability fix: incorporate adam's suggestions and nits fix: incorporated adam's feedback fix: incorporate adam's feedback
f53b2d9
to
7874784
Compare
Description
This PR covers up the following points
JIRA -> [ENT-7672, ENT-7673, ENT-7674, ENT-7565]
Here is the updated screen short
For all changes
Only if submitting a visual change