Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure budget_id query param is passed to analytics api #1049

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

adamstankiewicz
Copy link
Member

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5f1cb88) 83.20% compared to head (602320f) 83.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1049   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files         422      422           
  Lines        9006     9008    +2     
  Branches     1841     1843    +2     
=======================================
+ Hits         7493     7495    +2     
  Misses       1473     1473           
  Partials       40       40           
Files Coverage Δ
...dit-management/BudgetDetailActivityTabContents.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit 6a47c98 into master Oct 5, 2023
6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/pass-correct-args-useOfferRedemptions branch October 5, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants