Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: create zero state for bnr (#1179)" #1181

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

adamstankiewicz
Copy link
Member

This reverts commit 09da1ff.

The reverted commit is currently blocking the GoCD pipeline for production frontend-app-admin-portal, which needs to be re-built and re-deployed to production before 7pm Eastern to prevent a previously scheduled maintenance banner from appearing.

Once frontend-app-admin-portal has been re-built and re-deployed to production (with the latest commit from edx-internal to disable the scheduled maintenance banner), the reverted commit can be merged in again.

I did not want to release changes from stage to production that were untested, and have not heard from the original author of the reverted commit on whether the changes were ready to be released.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

green tests = lgtm

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (09da1ff) to head (e0ce334).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
- Coverage   85.36%   85.34%   -0.03%     
==========================================
  Files         498      497       -1     
  Lines       10854    10839      -15     
  Branches     2289     2283       -6     
==========================================
- Hits         9266     9251      -15     
  Misses       1544     1544              
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit 56ef352 into master Mar 7, 2024
5 of 6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/temp-revert-ent-8499 branch March 7, 2024 23:02
katrinan029 pushed a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants