Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create zero state for bnr #1182

Merged
merged 3 commits into from
Mar 8, 2024
Merged

feat: create zero state for bnr #1182

merged 3 commits into from
Mar 8, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Mar 8, 2024

Creating a zero state in the activity tab for Browse and Request courses.
Jira ticket

Screenshot 2024-03-05 at 10 46 03 AM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 requested review from adamstankiewicz and a team March 8, 2024 06:21
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (56ef352) to head (45b1a1a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
+ Coverage   85.34%   85.36%   +0.02%     
==========================================
  Files         497      498       +1     
  Lines       10839    10854      +15     
  Branches     2283     2289       +6     
==========================================
+ Hits         9251     9266      +15     
  Misses       1544     1544              
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 merged commit 7c27163 into master Mar 8, 2024
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-8499-1 branch March 8, 2024 15:06
katrinan029 pushed a commit that referenced this pull request Mar 8, 2024
* feat: create zero state for bnr

* fix: PR requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants