[ENT-8510] - fix: SSO tool not updating SSO records if no form fields are changed #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzawaleed01
force-pushed
the
hamza/ENT-8510
branch
from
ee7f5ff
to
9982bfd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1183 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 498 498
Lines 10862 10864 +2
Branches 2290 2291 +1
=======================================
+ Hits 9274 9276 +2
Misses 1544 1544
Partials 44 44 ☔ View full report in Codecov by Sentry. |
hamzawaleed01
force-pushed
the
hamza/ENT-8510
branch
from
9982bfd
to
dcb4160
Compare
hamzawaleed01
commented
Mar 11, 2024
Comment on lines
112
to
116
| await LmsApiService.fetchEnterpriseSsoOrchestrationRecord( | ||
| formFields?.uuid | ||
| ).catch(() => { | ||
| return { data: {} }; | ||
| }); |
There was a problem hiding this comment.
@alex-sheehan-edx I just gone reviewed code again, formFields is supposed to have many other attributes given here.
So, can we use any keys from formFields instead of making this separate API call?
hamzawaleed01
changed the title
zamanafzal
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes
Only if submitting a visual change