fix: hiding highlights for custom courses #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1191 +/- ##
==========================================
- Coverage 85.47% 85.46% -0.01%
==========================================
Files 508 508
Lines 11060 11074 +14
Branches 2326 2329 +3
==========================================
+ Hits 9453 9464 +11
- Misses 1563 1566 +3
Partials 44 44 ☔ View full report in Codecov by Sentry. |
marlonkeating
requested changes
Mar 29, 2024
| @@ -201,6 +224,7 @@ Sidebar.propTypes = { | |||
| enableAnalyticsScreen: PropTypes.bool, | |||
| onWidthChange: PropTypes.func, | |||
| isMobile: PropTypes.bool, | |||
| enterpriseGroupsV1: PropTypes.bool, | |||
There was a problem hiding this comment.
nit: Would help readability to have a name that's a bit more explicit that it is a feature flag, IMO
There was a problem hiding this comment.
I think it follows the same naming pattern as the other features, and you can see thats its being brought in from enterpriseFeatures
marlonkeating
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have groups feature turned on and they have a group that doesn't apply to all contexts, we do not want to show the highlights feature in the sidebar.
Jira ticket