Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract subscription uuid correctly #1193

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

muhammad-ammar
Copy link
Contributor

Description: Subscriptions UI component was not showing on the LPR page. Subscription UUID was parsed incorrectly.

JIRA: https://2u-internal.atlassian.net/browse/ENT-8600

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@muhammad-ammar muhammad-ammar force-pushed the ammar/lpr-subscriptions branch 2 times, most recently from 4d6717f to c975ae9 Compare April 1, 2024 06:21
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (7e36288) to head (60aaa9c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
- Coverage   85.47%   85.47%   -0.01%     
==========================================
  Files         508      508              
  Lines       11060    11060              
  Branches     2326     2326              
==========================================
- Hits         9454     9453       -1     
- Misses       1562     1563       +1     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please handle the lint errors and project coverage if possible for you. other than that LGTM 👍

@muhammad-ammar muhammad-ammar force-pushed the ammar/lpr-subscriptions branch 2 times, most recently from 1b3f90a to 8414e95 Compare April 1, 2024 10:46
@muhammad-ammar muhammad-ammar merged commit f85826b into master Apr 1, 2024
5 of 6 checks passed
@muhammad-ammar muhammad-ammar deleted the ammar/lpr-subscriptions branch April 1, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants