Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code styling issues for expiry logic #1198

Merged

Conversation

zwidekalanga
Copy link
Contributor

fix: code styling issues mentioned in the previous PR #1177

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ux-changes-expiry-logic branch 2 times, most recently from ba4245e to b6ad719 Compare April 11, 2024 13:48
@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ux-changes-expiry-logic branch from d2209e1 to f355243 Compare April 18, 2024 13:50
@macdiesel macdiesel merged commit 83b8906 into openedx:master Apr 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants