Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lms access link and budget filter #1229

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented May 17, 2024

https://2u-internal.atlassian.net/browse/ENT-8948

description before after
Checking multiple budget status filters hides the budgets Screenshot 2024-05-16 at 12 47 51 PM Screenshot 2024-05-16 at 12 48 36 PM
fix configure access tab to load Screenshot 2024-05-15 at 11 43 38 AM https://github.com/openedx/frontend-app-admin-portal/assets/71999631/4ca3d899-18cd-455b-9abf-6f360d6f94da

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

fix: lms access link and budget filter

fix: access link
@katrinan029 katrinan029 marked this pull request as ready for review May 17, 2024 20:57
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.34%. Comparing base (093c977) to head (6498274).

Files Patch % Lines
...anagement/BudgetDetailPageOverviewAvailability.jsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1229   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         537      537           
  Lines       11632    11632           
  Branches     2449     2449           
=======================================
  Hits         9927     9927           
+ Misses       1656     1655    -1     
- Partials       49       50    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 self-requested a review May 20, 2024 21:23
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katrinan029 katrinan029 merged commit 3fcadf5 into master May 21, 2024
5 of 6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-8948 branch May 21, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants