Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable toggle for react query devtools #1233

Merged
merged 3 commits into from
May 22, 2024
Merged

Conversation

brobro10000
Copy link
Member

Screen.Recording.2024-05-22.at.9.23.43.AM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.33%. Comparing base (5a3982c) to head (dc5af26).

Files Patch % Lines
src/components/App/index.jsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   85.37%   85.33%   -0.05%     
==========================================
  Files         537      537              
  Lines       11689    11695       +6     
  Branches     2463     2434      -29     
==========================================
  Hits         9980     9980              
- Misses       1657     1664       +7     
+ Partials       52       51       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return (
<QueryClientProvider client={queryClient}>
<ReactQueryDevtools />
{showReactQueryDevtools && (
<Suspense fallback={null}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: under-indented

{showReactQueryDevtools && (
  <Suspense fallback={null}>
    <ReactQueryDevtoolsProduction />
  </Suspense>
)}

@brobro10000 brobro10000 merged commit f3ee5ea into master May 22, 2024
4 of 6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-oncall-qol branch May 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants