Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate initial aggregates data on analytics v2 page #1293

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Sep 5, 2024

Description

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.52%. Comparing base (24478cf) to head (6a25b4b).
Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
src/components/AdvanceAnalyticsV2/Stats.jsx 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1293      +/-   ##
==========================================
+ Coverage   85.50%   85.52%   +0.02%     
==========================================
  Files         564      564              
  Lines       12325    12351      +26     
  Branches     2602     2581      -21     
==========================================
+ Hits        10538    10563      +25     
- Misses       1728     1730       +2     
+ Partials       59       58       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from ammar/integrate-advance-analytics-charts to master September 6, 2024 07:00
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9401 branch 3 times, most recently from 0fa1fd7 to 2b555db Compare September 9, 2024 13:02
Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Left some feedback.

@jajjibhai008 jajjibhai008 merged commit 2465202 into master Sep 10, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9401 branch September 10, 2024 13:40
@muhammad-ammar muhammad-ammar added the plotly-migration Work to migrate from Plotly DASH to PlotlyJS label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plotly-migration Work to migrate from Plotly DASH to PlotlyJS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants