Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memoized the course run ids passed to useApplicableCatalogs #1296

Merged
merged 2 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,14 @@ export const ApproveCouponCodeRequestModal = ({
onSuccess,
onClose,
}) => {
const courseRunIds = useMemo(() => [courseId], [courseId]);
const {
applicableCoupons,
isLoading: isLoadingApplicableCoupons,
error: loadApplicableCouponsError,
} = useApplicableCoupons({
enterpriseId: enterpriseCustomerUUID,
courseRunIds: [courseId],
courseRunIds,
coupons,
});
const [selectedCouponId, setSelectedCouponId] = useState();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,14 @@ export const ApproveLicenseRequestModal = ({
onClose,
}) => {
const { data: subscriptions } = useContext(SubscriptionContext);
const courseRunIds = useMemo(() => [courseId], [courseId]);
const {
applicableSubscriptions,
isLoading: isLoadingApplicableSubscriptions,
error: loadApplicableSubscriptionsError,
} = useApplicableSubscriptions({
enterpriseId: enterpriseCustomerUUID,
courseRunIds: [courseId],
courseRunIds,
subscriptions,
});

Expand Down Expand Up @@ -92,7 +93,7 @@ export const ApproveLicenseRequestModal = ({
defaultMessage="Approve License Request"
description="Title for the approve license request modal."
/>
)}
)}
isOpen={isOpen}
hasCloseButton
onClose={onClose}
Expand Down
Loading