Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate deprecated Table to DataTable for CompletedLearnersTable #1303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zwidekalanga
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Screenshot

Screenshot 2024-09-16 at 1 11 08 PM

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ENT-8451 branch 3 times, most recently from 76d42bf to 99a7b8a Compare September 16, 2024 12:46
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 80.70175% with 11 lines in your changes missing coverage. Please review.

Project coverage is 85.58%. Comparing base (152488a) to head (85d7d1c).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...components/Admin/data/hooks/useGenericTableData.js 75.75% 6 Missing and 2 partials ⚠️
...onents/Admin/data/hooks/useModuleActivityReport.js 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
- Coverage   85.60%   85.58%   -0.03%     
==========================================
  Files         566      568       +2     
  Lines       12467    12505      +38     
  Branches     2643     2608      -35     
==========================================
+ Hits        10672    10702      +30     
- Misses       1736     1743       +7     
- Partials       59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/ENT-8451 branch 3 times, most recently from c09fe89 to c3d5a5b Compare September 17, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant