Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated courseKey with courseTitle for charts #1304

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

irfanuddinahmad
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (d78920c) to head (6746379).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1304      +/-   ##
==========================================
- Coverage   85.60%   85.59%   -0.01%     
==========================================
  Files         575      575              
  Lines       12672    12672              
  Branches     2691     2648      -43     
==========================================
- Hits        10848    10847       -1     
- Misses       1762     1764       +2     
+ Partials       62       61       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should truncate long titles. We can set a character limit and ensure that titles are truncated at word boundaries and an ellipsis is added at the end to indicate truncation.

@irfanuddinahmad irfanuddinahmad merged commit e7aaa47 into master Sep 25, 2024
1 check passed
@irfanuddinahmad irfanuddinahmad deleted the iahmad/ENT-9438 branch September 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants