Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing the trigger of member status #1308

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: changing the trigger of member status #1308

merged 2 commits into from
Sep 24, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Sep 17, 2024

Jira Ticket - quick change from a click trigger to hover on the status component

Screen.Recording.2024-09-17.at.3.56.59.PM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 requested a review from a team September 17, 2024 21:59
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (9aef684) to head (ef93959).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
+ Coverage   85.62%   85.65%   +0.03%     
==========================================
  Files         570      576       +6     
  Lines       12676    12704      +28     
  Branches     2690     2696       +6     
==========================================
+ Hits        10854    10882      +28     
  Misses       1761     1761              
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marlonkeating marlonkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but might we do it for Admin Assign members as well?

@kiram15 kiram15 enabled auto-merge (squash) September 24, 2024 22:26
@kiram15 kiram15 merged commit 045eefb into master Sep 24, 2024
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9431 branch September 24, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants