Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download csv button text for data tables #1345

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Nov 8, 2024

Description
Issues:

  • Currently on Engagements, Completions, and Leaderboard tabs. The label for the CSV download button for the table is incorrect. All labels have the same text Download Enrollments CSV
  • By default, Data Granularity is Daily which is not match with currently working analytics.
  • Numbers on Stats are not compacting as per original analytics

Fix:

  • we change the labels for each tab.

    • Engagements: Download Engagements CSV
    • Completions: Download Completions CSV
    • Leaderboard: Download Leaderboard CSV
  • Set Week as the default granularity

  • If the integer count is more than four then compact that number otherwise show it as is

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (dfaa444) to head (01b37cb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1345   +/-   ##
=======================================
  Coverage   85.78%   85.78%           
=======================================
  Files         598      598           
  Lines       13119    13121    +2     
  Branches     2732     2779   +47     
=======================================
+ Hits        11254    11256    +2     
+ Misses       1800     1799    -1     
- Partials       65       66    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 merged commit 0f957c5 into master Nov 8, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9705 branch November 8, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants