-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the display of username suggestions #1270
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @khudym! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
=======================================
Coverage 87.69% 87.69%
=======================================
Files 124 124
Lines 2299 2300 +1
Branches 642 643 +1
=======================================
+ Hits 2016 2017 +1
Misses 274 274
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Friendly follow-up on this, @openedx/2u-vanguards. Thanks! |
092e1e7
to
30e0262
Compare
Hi @openedx/vanguards @openedx/2u-vanguards! I think you are still maintainers of this repo. Just checking in to see if someone could please take a look here? |
30e0262
to
e39d41f
Compare
Description
Username suggestions functionality has been corrected to ensure proper behaviour.
Related Pull Requests
PR to the open-release/redwood.master branch: #1279
PR to the open-release/quince.master branch: #1278
Steps to Reproduce:
1. suggestions being displayed in the wrong place
Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> Click on field "Public username"
suggestions_rendering_bug.mov
2. impossible to enter suggestions field using the keyboard
Open register page -> Enter some string into field "Full name" (e.g. Jack Smith) -> press Tab button until you get to the "Public username" field
suggestions_keyboard.mov
After changes:
1. suggestions being displayed in the wrong place
fixed_suggestions_rendering_bug.mov
2. impossible to enter suggestions field using the keyboard
fixed_suggestions_keyboard.mov
Merge Checklist
Post-merge Checklist