feat: Remove taxonomy export id prompt (#955)

openedx · Apr 25, 2024 · 4146fa6 · 4146fa6
1 parent be71668
commit 4146fa6
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 30 deletions.
diff --git a/src/taxonomy/data/apiHooks.js b/src/taxonomy/data/apiHooks.js
@@ -113,18 +113,16 @@ export const useImportNewTaxonomy = () => {
     *   any,
     *   {
     *     name: string,
-    *     exportId: string,
     *     description: string,
     *     file: File,
     *   }
     * >}
     */
     mutationFn: async ({
-      name, exportId, description, file,
+      name, description, file,
     }) => {
       const formData = new FormData();
       formData.append('taxonomy_name', name);
-      formData.append('taxonomy_export_id', exportId);
       formData.append('taxonomy_description', description);
       formData.append('file', file);
 

diff --git a/src/taxonomy/data/apiHooks.test.jsx b/src/taxonomy/data/apiHooks.test.jsx
@@ -64,7 +64,6 @@ describe('import taxonomy api calls', () => {
     const mutateResult = await result.current.mutateAsync({
       name: 'Taxonomy name',
       description: 'Taxonomy description',
-      exportId: 'taxonomy_export_id',
       file: emptyFile,
     });
 

diff --git a/src/taxonomy/import-tags/utils.js b/src/taxonomy/import-tags/utils.js
@@ -68,26 +68,6 @@ export const importTaxonomy = async (intl, importMutation) => { // eslint-disabl
     return taxonomyName;
   };
 
-  const getTaxonomyExportId = () => {
-    let taxonomyExportId = null;
-    const validationRegex = /^[\p{L}\w\-.]+$/u;
-    while (!taxonomyExportId) {
-      taxonomyExportId = prompt(intl.formatMessage(messages.promptTaxonomyExportId));
-
-      if (taxonomyExportId == null) {
-        break;
-      }
-
-      if (!taxonomyExportId) {
-        alert(intl.formatMessage(messages.promptTaxonomyExportIdRequired));
-      } else if (!validationRegex.test(taxonomyExportId)) {
-        alert(intl.formatMessage(messages.promptTaxonomyExportIdInvalid));
-        taxonomyExportId = null;
-      }
-    }
-    return taxonomyExportId;
-  };
-
   const getTaxonomyDescription = () => prompt(intl.formatMessage(messages.promptTaxonomyDescription));
 
   const file = await selectFile();
@@ -101,19 +81,13 @@ export const importTaxonomy = async (intl, importMutation) => { // eslint-disabl
     return;
   }
 
-  const exportId = getTaxonomyExportId();
-  if (exportId == null) {
-    return;
-  }
-
   const description = getTaxonomyDescription();
   if (description == null) {
     return;
   }
 
   importMutation.mutateAsync({
     name,
-    exportId,
     description,
     file,
   }).then(() => {