Skip to content

Commit

Permalink
Fix SelectableBox problems (#886)
Browse files Browse the repository at this point in the history
Due to a bug in the SelectableBox component, selecting values was not possible in different components throughout this MFE.

This fixes the Gallery and the Select Problem Types components by updating the FLCC version and replacing the SelectableBox copy with an import from FLCC.

For a full bug description see #880.
  • Loading branch information
jesperhodge authored Mar 11, 2024
1 parent dad4bd5 commit b5a2876
Show file tree
Hide file tree
Showing 27 changed files with 7 additions and 1,852 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@edx/frontend-component-footer": "^13.0.2",
"@edx/frontend-component-header": "^5.0.2",
"@edx/frontend-enterprise-hotjar": "^2.0.0",
"@edx/frontend-lib-content-components": "^2.1.1",
"@edx/frontend-lib-content-components": "^2.1.3",
"@edx/frontend-platform": "7.0.1",
"@edx/openedx-atlas": "^0.6.0",
"@fortawesome/fontawesome-svg-core": "1.2.36",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import React, { useContext, useEffect, useState } from 'react';
import PropTypes from 'prop-types';
import { injectIntl, intlShape, FormattedMessage } from '@edx/frontend-platform/i18n';
// SelectableBox in paragon has a bug only visible on stage where you can't change selection. So we override it
import { SelectableBox } from '@edx/frontend-lib-content-components';
import {
ActionRow,
Button,
Expand All @@ -9,7 +11,6 @@ import {
ModalDialog,
useCheckboxSetValues,
} from '@openedx/paragon';
import SelectableBox from '../../../../generic/SelectableBox';
import messages from './messages';
import { getCheckedFilters, getFilterOptions, processFilters } from './utils';

Expand Down
145 changes: 0 additions & 145 deletions src/generic/SelectableBox/FormCheckbox.jsx

This file was deleted.

68 changes: 0 additions & 68 deletions src/generic/SelectableBox/FormCheckboxSet.jsx

This file was deleted.

77 changes: 0 additions & 77 deletions src/generic/SelectableBox/FormCheckboxSetContext.jsx

This file was deleted.

56 changes: 0 additions & 56 deletions src/generic/SelectableBox/FormControlFeedback.jsx

This file was deleted.

Loading

0 comments on commit b5a2876

Please sign in to comment.