feat: [AXIMST-46] Course unit - Drag And Drop For Xblocks (#158)

* feat: [AXIMST-46] Drag And Drop For Xblocks

* feat: added tests

* refactor: refactoring after review

src/course-outline/CourseOutline.jsx

@@ -45,12 +45,12 @@ import HighlightsModal from './highlights-modal/HighlightsModal';
 import EmptyPlaceholder from './empty-placeholder/EmptyPlaceholder';
 import PublishModal from './publish-modal/PublishModal';
 import PageAlerts from './page-alerts/PageAlerts';
-import DraggableList from './drag-helper/DraggableList';
+import DraggableList from '../generic/drag-helper/DraggableList';
 import {
   canMoveSection,
   possibleUnitMoves,
   possibleSubsectionMoves,
-} from './drag-helper/utils';
+} from '../generic/drag-helper/utils';
 import { useCourseOutline } from './hooks';
 import messages from './messages';
 

src/course-outline/CourseOutline.scss

@@ -7,7 +7,6 @@
 @import "./empty-placeholder/EmptyPlaceholder";
 @import "./highlights-modal/HighlightsModal";
 @import "./publish-modal/PublishModal";
-@import "./drag-helper/SortableItem";
 @import "./xblock-status/XBlockStatus";
 
 div.row:has(> div > div.highlight) {

src/course-outline/CourseOutline.test.jsx

@@ -56,7 +56,7 @@ import {
   moveUnitOver,
   moveSubsection,
   moveUnit,
-} from './drag-helper/utils';
+} from '../generic/drag-helper/utils';
 
 let axiosMock;
 let store;

src/course-outline/section-card/SectionCard.jsx

@@ -13,8 +13,8 @@ import classNames from 'classnames';
 import { setCurrentItem, setCurrentSection } from '../data/slice';
 import { RequestStatus } from '../../data/constants';
 import CardHeader from '../card-header/CardHeader';
-import SortableItem from '../drag-helper/SortableItem';
-import { DragContext } from '../drag-helper/DragContextProvider';
+import SortableItem from '../../generic/drag-helper/SortableItem';
+import { DragContext } from '../../generic/drag-helper/DragContextProvider';
 import TitleButton from '../card-header/TitleButton';
 import XBlockStatus from '../xblock-status/XBlockStatus';
 import { getItemStatus, getItemStatusBorder, scrollToElement } from '../utils';

src/course-outline/subsection-card/SubsectionCard.jsx

@@ -14,8 +14,8 @@ import { isEmpty } from 'lodash';
 import { setCurrentItem, setCurrentSection, setCurrentSubsection } from '../data/slice';
 import { RequestStatus } from '../../data/constants';
 import CardHeader from '../card-header/CardHeader';
-import SortableItem from '../drag-helper/SortableItem';
-import { DragContext } from '../drag-helper/DragContextProvider';
+import SortableItem from '../../generic/drag-helper/SortableItem';
+import { DragContext } from '../../generic/drag-helper/DragContextProvider';
 import { useCopyToClipboard, PasteComponent } from '../../generic/clipboard';
 import TitleButton from '../card-header/TitleButton';
 import XBlockStatus from '../xblock-status/XBlockStatus';

src/course-outline/unit-card/UnitCard.jsx

@@ -9,7 +9,7 @@ import { useSearchParams } from 'react-router-dom';
 import { setCurrentItem, setCurrentSection, setCurrentSubsection } from '../data/slice';
 import { RequestStatus } from '../../data/constants';
 import CardHeader from '../card-header/CardHeader';
-import SortableItem from '../drag-helper/SortableItem';
+import SortableItem from '../../generic/drag-helper/SortableItem';
 import TitleLink from '../card-header/TitleLink';
 import XBlockStatus from '../xblock-status/XBlockStatus';
 import { getItemStatus, getItemStatusBorder, scrollToElement } from '../utils';

src/course-unit/CourseUnit.jsx

@@ -1,10 +1,12 @@
+import { useEffect, useMemo, useState } from 'react';
 import PropTypes from 'prop-types';
 import { useSelector } from 'react-redux';
 import { useParams } from 'react-router-dom';
 import { Container, Layout, Stack } from '@openedx/paragon';
 import { useIntl, injectIntl } from '@edx/frontend-platform/i18n';
-import { ErrorAlert } from '@edx/frontend-lib-content-components';
+import { DraggableList, ErrorAlert } from '@edx/frontend-lib-content-components';
 import { Warning as WarningIcon } from '@openedx/paragon/icons';
+import { SortableContext, verticalListSortingStrategy } from '@dnd-kit/sortable';
 
 import { getProcessingNotification } from '../generic/processing-notification/data/selectors';
 import SubHeader from '../generic/sub-header/SubHeader';
@@ -56,10 +58,20 @@ const CourseUnit = ({ courseId }) => {
     handleCreateNewCourseXBlock,
     handleConfigureSubmit,
     courseVerticalChildren,
+    handleXBlockDragAndDrop,
     canPasteComponent,
   } = useCourseUnit({ courseId, blockId });
 
-  document.title = getPageHeadTitle('', unitTitle);
+  const initialXBlocksData = useMemo(() => courseVerticalChildren.children ?? [], [courseVerticalChildren.children]);
+  const [unitXBlocks, setUnitXBlocks] = useState(initialXBlocksData);
+
+  useEffect(() => {
+    document.title = getPageHeadTitle('', unitTitle);
+  }, [unitTitle]);
+
+  useEffect(() => {
+    setUnitXBlocks(courseVerticalChildren.children);
+  }, [courseVerticalChildren.children]);
 
   const {
     isShow: isShowProcessingNotification,
@@ -78,6 +90,12 @@ const CourseUnit = ({ courseId }) => {
     );
   }
 
+  const finalizeXBlockOrder = () => (newXBlocks) => {
+    handleXBlockDragAndDrop(newXBlocks.map(xBlock => xBlock.id), () => {
+      setUnitXBlocks(initialXBlocksData);
+    });
+  };
+
   return (
     <>
       <Container size="xl" className="course-unit px-4">
@@ -122,6 +140,7 @@ const CourseUnit = ({ courseId }) => {
             <Layout.Element>
               {currentlyVisibleToStudents && (
                 <AlertMessage
+                  className="course-unit__alert"
                   title={intl.formatMessage(messages.alertUnpublishedVersion)}
                   variant="warning"
                   icon={WarningIcon}
@@ -133,24 +152,37 @@ const CourseUnit = ({ courseId }) => {
                   courseId={courseId}
                 />
               )}
-              <Stack gap={4} className="mb-4">
-                {courseVerticalChildren.children.map(({
-                  name, blockId: id, blockType: type, shouldScroll, userPartitionInfo, validationMessages,
-                }) => (
-                  <CourseXBlock
-                    id={id}
-                    key={id}
-                    title={name}
-                    type={type}
-                    blockId={blockId}
-                    validationMessages={validationMessages}
-                    shouldScroll={shouldScroll}
-                    unitXBlockActions={unitXBlockActions}
-                    handleConfigureSubmit={handleConfigureSubmit}
-                    data-testid="course-xblock"
-                    userPartitionInfo={userPartitionInfo}
-                  />
-                ))}
+              <Stack className="mb-4 course-unit__xblocks">
+                <DraggableList
+                  itemList={unitXBlocks}
+                  setState={setUnitXBlocks}
+                  updateOrder={finalizeXBlockOrder}
+                >
+                  <SortableContext
+                    id="root"
+                    items={unitXBlocks}
+                    strategy={verticalListSortingStrategy}
+                  >
+                    {unitXBlocks.map(({
+                      name, id, blockType: type, shouldScroll, userPartitionInfo, validationMessages,
+                    }) => (
+                      <CourseXBlock
+                        id={id}
+                        key={id}
+                        title={name}
+                        type={type}
+                        blockId={blockId}
+                        validationMessages={validationMessages}
+                        shouldScroll={shouldScroll}
+                        handleConfigureSubmit={handleConfigureSubmit}
+                        unitXBlockActions={unitXBlockActions}
+                        data-testid="course-xblock"
+                        className="course-unit__xblock"
+                        userPartitionInfo={userPartitionInfo}
+                      />
+                    ))}
+                  </SortableContext>
+                </DraggableList>
               </Stack>
               <AddComponent
                 blockId={blockId}

src/course-unit/CourseUnit.scss

@@ -4,3 +4,7 @@
 @import "./course-xblock/CourseXBlock";
 @import "./sidebar/Sidebar";
 @import "./header-title/HeaderTitle";
+
+.course-unit__alert {
+  margin-bottom: 1.75rem;
+}

src/course-unit/CourseUnit.test.jsx

@@ -54,6 +54,7 @@ import addComponentMessages from './add-component/messages';
 import { PUBLISH_TYPES, UNIT_VISIBILITY_STATES } from './constants';
 import messages from './messages';
 import { getContentTaxonomyTagsApiUrl, getContentTaxonomyTagsCountApiUrl } from '../content-tags-drawer/data/api';
+import { RequestStatus } from '../data/constants';
 
 let axiosMock;
 let store;
@@ -1132,7 +1133,9 @@ describe('<CourseUnit />', () => {
       userEvent.click(getByRole('button', { name: sidebarMessages.actionButtonCopyUnitTitle.defaultMessage }));
       userEvent.click(getByRole('button', { name: messages.pasteButtonText.defaultMessage }));
 
-      expect(getAllByTestId('course-xblock')).toHaveLength(2);
+      await waitFor(() => {
+        expect(getAllByTestId('course-xblock')).toHaveLength(2);
+      });
 
       axiosMock
         .onGet(getCourseVerticalChildrenApiUrl(blockId))
@@ -1219,9 +1222,11 @@ describe('<CourseUnit />', () => {
         courseUnitMock,
       ]);
 
-      units = getAllByTestId('course-unit-btn');
-      const courseUnits = courseSectionVerticalMock.xblock_info.ancestor_info.ancestors[0].child_info.children;
-      expect(units).toHaveLength(courseUnits.length);
+      await waitFor(() => {
+        units = getAllByTestId('course-unit-btn');
+        const courseUnits = courseSectionVerticalMock.xblock_info.ancestor_info.ancestors[0].child_info.children;
+        expect(units).toHaveLength(courseUnits.length);
+      });
 
       axiosMock
         .onPost(postXBlockBaseApiUrl(), postXBlockBody)
@@ -1442,4 +1447,56 @@ describe('<CourseUnit />', () => {
       )).not.toBeInTheDocument();
     });
   });
+
+  describe('Drag and drop', () => {
+    it('checks xblock list is restored to original order when API call fails', async () => {
+      const { findAllByRole } = render(<RootWrapper />);
+
+      const xBlocksDraggers = await findAllByRole('button', { name: 'Drag to reorder' });
+      const draggableButton = xBlocksDraggers[1];
+
+      axiosMock
+        .onPut(getXBlockBaseApiUrl(blockId))
+        .reply(500, { dummy: 'value' });
+
+      const xBlock1 = store.getState().courseUnit.courseVerticalChildren.children[0].id;
+
+      fireEvent.keyDown(draggableButton, { key: 'ArrowUp' });
+
+      await waitFor(async () => {
+        fireEvent.keyDown(draggableButton, { code: 'Space' });
+
+        const saveStatus = store.getState().courseUnit.savingStatus;
+        expect(saveStatus).toEqual(RequestStatus.FAILED);
+      });
+
+      const xBlock1New = store.getState().courseUnit.courseVerticalChildren.children[0].id;
+      expect(xBlock1).toBe(xBlock1New);
+    });
+
+    it('check that new xblock list is saved when dragged', async () => {
+      const { findAllByRole } = render(<RootWrapper />);
+
+      const xBlocksDraggers = await findAllByRole('button', { name: 'Drag to reorder' });
+      const draggableButton = xBlocksDraggers[1];
+
+      axiosMock
+        .onPut(getXBlockBaseApiUrl(blockId))
+        .reply(200, { dummy: 'value' });
+
+      const xBlock1 = store.getState().courseUnit.courseVerticalChildren.children[0].id;
+
+      fireEvent.keyDown(draggableButton, { key: 'ArrowUp' });
+
+      await waitFor(async () => {
+        fireEvent.keyDown(draggableButton, { code: 'Space' });
+
+        const saveStatus = store.getState().courseUnit.savingStatus;
+        expect(saveStatus).toEqual(RequestStatus.SUCCESSFUL);
+      });
+
+      const xBlock2 = store.getState().courseUnit.courseVerticalChildren.children[1].id;
+      expect(xBlock1).toBe(xBlock2);
+    });
+  });
 });

src/course-unit/clipboard/paste-notification/index.jsx

@@ -34,6 +34,7 @@ const PastNotificationAlert = ({ staticFileNotices, courseId }) => {
       {hasConflictingErrors && (
         <AlertMessage
           data-testid="has-conflicting-errors-alert"
+          className="course-unit__alert"
           title={intl.formatMessage(messages.hasConflictingErrorsTitle)}
           onClose={() => handleCloseNotificationAlert('conflictingFilesAlert')}
           description={(
@@ -56,6 +57,7 @@ const PastNotificationAlert = ({ staticFileNotices, courseId }) => {
       {hasErrorFiles && (
         <AlertMessage
           data-testid="has-error-files-alert"
+          className="course-unit__alert"
           title={intl.formatMessage(messages.hasErrorsTitle)}
           onClose={() => handleCloseNotificationAlert('errorFilesAlert')}
           description={(
@@ -72,6 +74,7 @@ const PastNotificationAlert = ({ staticFileNotices, courseId }) => {
       {hasNewFiles && (
         <AlertMessage
           data-testid="has-new-files-alert"
+          className="course-unit__alert"
           title={intl.formatMessage(messages.hasNewFilesTitle)}
           onClose={() => handleCloseNotificationAlert('newFilesAlert')}
           description={(
@@ -97,11 +100,16 @@ const PastNotificationAlert = ({ staticFileNotices, courseId }) => {
 
 PastNotificationAlert.propTypes = {
   courseId: PropTypes.string.isRequired,
-  staticFileNotices: PropTypes.shape({
-    conflictingFiles: PropTypes.arrayOf(PropTypes.string),
-    errorFiles: PropTypes.arrayOf(PropTypes.string),
-    newFiles: PropTypes.arrayOf(PropTypes.string),
-  }).isRequired,
+  staticFileNotices:
+    PropTypes.objectOf({
+      conflictingFiles: PropTypes.arrayOf(PropTypes.string),
+      errorFiles: PropTypes.arrayOf(PropTypes.string),
+      newFiles: PropTypes.arrayOf(PropTypes.string),
+    }),
+};
+
+PastNotificationAlert.defaultProps = {
+  staticFileNotices: {},
 };
 
 export default PastNotificationAlert;

src/course-unit/course-xblock/CourseXBlock.jsx

@@ -11,6 +11,7 @@ import { useIntl } from '@edx/frontend-platform/i18n';
 import { getCanEdit, getCourseId } from 'CourseAuthoring/course-unit/data/selectors';
 import DeleteModal from '../../generic/delete-modal/DeleteModal';
 import ConfigureModal from '../../generic/configure-modal/ConfigureModal';
+import SortableItem from '../../generic/drag-helper/SortableItem';
 import { scrollToElement } from '../../course-outline/utils';
 import { COURSE_BLOCK_NAMES } from '../../constants';
 import { copyToClipboard } from '../../generic/data/thunks';
@@ -71,16 +72,21 @@ const CourseXBlock = ({
 
   return (
     <div ref={courseXBlockElementRef} {...props}>
-      <Card className="mb-1">
+      <Card
+        as={SortableItem}
+        id={id}
+        draggable
+        category="xblock"
+        componentStyle={{ marginBottom: 0 }}
+      >
         <Card.Header
           title={title}
           subtitle={visibilityMessage}
           actions={(
-            <ActionRow>
+            <ActionRow className="mr-2">
               <IconButton
                 alt={intl.formatMessage(messages.blockAltButtonEdit)}
                 iconAs={EditIcon}
-                size="md"
                 onClick={handleEdit}
               />
               <Dropdown>
@@ -89,7 +95,6 @@ const CourseXBlock = ({
                   as={IconButton}
                   src={MoveVertIcon}
                   alt={intl.formatMessage(messages.blockActionsDropdownAlt)}
-                  size="sm"
                   iconAs={Icon}
                 />
                 <Dropdown.Menu>
@@ -127,7 +132,6 @@ const CourseXBlock = ({
               />
             </ActionRow>
           )}
-          size="md"
         />
         <Card.Section>
           <XBlockMessages validationMessages={validationMessages} />

src/course-unit/course-xblock/CourseXBlock.scss

@@ -1,5 +1,9 @@
 .course-unit {
   .course-unit__xblocks {
+    .course-unit__xblock:not(:first-child) {
+      margin-top: 1.75rem;
+    }
+
     .pgn__card-header {
       display: flex;
       justify-content: space-between;