Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Change video transcript text #1453

Open
jmakowski1123 opened this issue Oct 31, 2024 · 3 comments · Fixed by #1459
Open

Bug: Change video transcript text #1453

jmakowski1123 opened this issue Oct 31, 2024 · 3 comments · Fixed by #1459
Assignees
@navinkarkera
Labels
bug Report of or fix for something that isn't working as intended high

Comments

@jmakowski1123
Copy link

Since transcripts will not be supported yet in Sumac, this text should read: Video transcripts are not yet supported.
Or, if it's easier to just remove that text entirely, that's fine too.

Image
@jmakowski1123 jmakowski1123 mentioned this issue Oct 31, 2024
Open
@bradenmacdonald bradenmacdonald added the bug Report of or fix for something that isn't working as intended label Oct 31, 2024
@navinkarkera navinkarkera self-assigned this Nov 4, 2024
@navinkarkera navinkarkera mentioned this issue Nov 4, 2024
Merged
navinkarkera added a commit to open-craft/frontend-app-authoring that referenced this issue Nov 6, 2024
@navinkarkera
chore: hide transcripts in video preview for library (openedx#1459)
6810048 
Fixes: openedx#1453
(cherry picked from commit e118eb5)
@navinkarkera navinkarkera mentioned this issue Nov 6, 2024
Merged
ChrisChV pushed a commit that referenced this issue Nov 7, 2024
@navinkarkera
chore: hide transcripts in video preview for library (#1459) (#1474)
9304a83 
Fixes: #1453
(cherry picked from commit e118eb5)
@pomegranited pomegranited reopened this Nov 7, 2024
@pomegranited
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@jmakowski1123
Copy link
Author

Assuming the approach was to remove it, yes?

@navinkarkera
Copy link
Contributor

@jmakowski1123 Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navinkarkera navinkarkera

Labels
bug Report of or fix for something that isn't working as intended high
Projects
Libraries Overhaul
Status: Ready for AC testing
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: hide transcripts in video preview for library open-craft/frontend-app-authoring
4 participants
@bradenmacdonald @pomegranited @navinkarkera @jmakowski1123