Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update mapToStateProps to match changes in TinyMceWidget #1133

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

KristinAoki
Copy link
Member

Description

This PR fixes pages throwing errors when the WysiwygEditor used due to the redux state variable used in the child TinyMceWidget.

Supporting information

JIRA Ticket: TNL-11665 🔒

The Updates feature in Studio (content > Updates) is giving an “unexpected application error” when course teams click the “+ New update” button. This is blocking course teams from communicating with their learners.

Testing instructions

  1. Navigate to the Course Updates page
  2. Confirm that existing updates and handouts load
  3. Click "+ New update"
  4. Confirm that editor loads
  5. Add content and click "Post"
  6. Click the edit button for an update
  7. Confirm that the editor loads
  8. Click "Cancel"
  9. Click the edit button for handouts
  10. Confirm that the editor loads
  11. Click "Cancel"
  12. Navigate to the Schedule and details page
  13. Confirm that the page loads as expected

Other information

This PR is dependent on frontend-lib-content-components #489. The package upgrade generated by #489 will be included in this PR

@KristinAoki KristinAoki requested a review from a team as a code owner June 26, 2024 23:10
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (a4859d2) to head (e6f8f53).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1133   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files         696      696           
  Lines       12368    12369    +1     
  Branches     2701     2707    +6     
=======================================
+ Hits        11461    11462    +1     
  Misses        875      875           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit eb3e6fa into master Jun 27, 2024
6 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/update-mapStateToProps-attributes branch June 27, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants