-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: responsiveness on library authoring sidebar [FC-0062] #1293
fix: responsiveness on library authoring sidebar [FC-0062] #1293
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
f815e38
to
caee0dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1293 +/- ##
==========================================
+ Coverage 92.34% 92.47% +0.12%
==========================================
Files 1023 1025 +2
Lines 18877 18975 +98
Branches 4023 4034 +11
==========================================
+ Hits 17432 17547 +115
+ Misses 1376 1360 -16
+ Partials 69 68 -1 ☔ View full report in Codecov by Sentry. |
Looks nice @rpenido! Does this also make the width of the sidebar more stable/consistent? |
Yes! The width is now fixed on Edit: the sandbox is updated with this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @rpenido This is working great, and fixes the horizontal jiggle that Sam noticed.
There's still a slight vertical shifting when switching between Library and Component info sidebars, maybe because of the outline on the Library Info button? Would be cool if you could fix that too, but doesn't have to block us here.
vertical_jiggle.mp4
- I tested this on my tutor devstack using the PR test instructions.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentationN/A -
User-facing strings are extracted for translationN/A
Good catch @pomegranited! |
Description
This PR fixes the library authoring sidebar width and change the card grid to have auto-columns instead for breakpoints.
Before:
After:
Responsiveness:
Tabs
More information
Part of:
Testing instructions
Private ref: FAL-3820