-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete collection [FC-0062] #1333
Merged
+406
−108
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
415c13b
feat: delete collection
navinkarkera 4abc7bb
refactor: add option to change delete modal variant
navinkarkera b450d13
fix: lint issues
navinkarkera bf9e9fc
feat: update button status on delete
navinkarkera 3128590
test: add tests for collection delete
navinkarkera c8dd4be
fix: lint issues
navinkarkera ed6b0db
refactor: rebase upstream
navinkarkera 84bb5ce
refactor: use toast component in processing notification
navinkarkera b2ae41b
refactor: improve css
navinkarkera 910b465
fix: collection sidebar behaviour on delete
navinkarkera a2f1cf1
fix: lint issues
navinkarkera a74199d
fix: processing notification close button visibility
navinkarkera cd7cbf3
test: fix processing notification tests
navinkarkera 3adc3ea
fix: tests
navinkarkera 6217089
fix: lint issues
navinkarkera 5672b91
refactor: move toasts to right side
navinkarkera 71f735a
fix: resolve conflicts
navinkarkera 316166b
refactor: use screen and remove unnecessary args
navinkarkera 26da705
Merge branch 'master' into navin/delete-collection
ChrisChV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: rebase upstream
commit ed6b0db77e8e146b056359cc7c540c5f2794a146
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for testing this feature so thoroughly!